This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix PR c++/28052: ICE on invalid bitfield


Volker Reichelt wrote:

> 2006-06-16  Volker Reichelt  <reichelt@igpm.rwth-aachen.de>
> 
> 	PR c++/28052
> 	* init.c (push_base_cleanups): Skip members with invalid types.
> 	* typeck.c (build_class_member_access_expr): Robustify.

> -  if (object == error_mark_node || member == error_mark_node)
> +  if (object == error_mark_node || error_operand_p (member))
>      return error_mark_node;

You might as well check error_operand_p for object too; in general,
expressions are invalid if they are either error_mark or have erroneous
type.

OK with that change.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]