This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR28045
- From: Roger Sayle <roger at eyesopen dot com>
- To: Richard Guenther <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 19 Jun 2006 08:08:21 -0600 (MDT)
- Subject: Re: [PATCH] Fix PR28045
On Mon, 19 Jun 2006, Richard Guenther wrote:
> 2006-06-18 Richard Guenther <rguenther@suse.de>
>
> PR middle-end/28045
> * fold-const.c (operand_equal_p): Check if the argument types
> have the same precision before stripping NOPs.
>
> * gcc.dg/torture/pr28045.c: New testcase.
This is OK for mainline, and for the affected active branches after
a few days without problems. Could you keep an eye out for adverse
impact on benchmarks? Fortunately, this should only affect bitfields,
where TYPE_PRECISION != GET_MODE_BITSIZE (TYPE_MODE), but in those
cases it may disable optimizations that we may have been "lucky"
with previously.
Thanks for fixing this.
Roger
--
p.s. You might think about putting slightly more descriptive text
in your subject lines. :-)