This is the mail archive of the
mailing list for the GCC project.
Re: Patch queue and reviewing (Was Re: Generator programs can only be built with optimization enabled?)
- From: "Manuel LÃpez-IbÃÃez" <lopezibanez at gmail dot com>
- To: "Mike Stump" <mrs at apple dot com>
- Cc: "Joe Buck" <Joe dot Buck at synopsys dot com>, "Daniel Berlin" <dberlin at dberlin dot org>, "Eric Botcazou" <ebotcazou at libertysurf dot fr>, "Paolo Bonzini" <paolo dot bonzini at lu dot unisi dot ch>, gcc at gcc dot gnu dot org, "Mark Mitchell" <mark at codesourcery dot com>, "GCC Patches" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 15 Jun 2006 10:34:54 +0100
- Subject: Re: Patch queue and reviewing (Was Re: Generator programs can only be built with optimization enabled?)
- References: <448C7B05.firstname.lastname@example.org> <448D9BE9.email@example.com> <448E652E.firstname.lastname@example.org> <email@example.com> <448F8170.firstname.lastname@example.org> <96F5A03B-F997-4859-BD28-F71727B6313B@apple.com> <20060614185149.GF21013@synopsys.com> <A2CF6C09-888D-4F85-AA24-E88A8274D48B@apple.com>
On 15/06/06, Mike Stump <email@example.com> wrote:
For example, would be nice to have a batch tester that
would bootstrap and regression test on 2-5 platforms for all patch
submitters post approval but pre-checkin. If any regressions, dump
all patches and move on to the next set, repeat as fast as possible.
I am new to the project so please don't take me too seriously if I am
saying some dumb thing: why review a patch that doesn't pass bootstrap
and check? I mean, there is a patch queue, you put your patch or patch
set in the queue, it gets bootstrapped and tested as you said on 2-5
patforms, then either it passes and a notification is send to the
potential reviewers or either it doesn't and it is rejected
automatically by sending all the information to the submitter and
being dropped from the queue.
Maintainers said that they are overwhelmed by the amount of work
required to review. Post-approval testing seems just a waste of time