This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix PR c++/27933: ICE with invalid "using"
On 12 Jun, Mark Mitchell wrote:
> Volker Reichelt wrote:
>
>> 2006-06-07 Volker Reichelt <reichelt@igpm.rwth-aachen.de>
>>
>> PR c++/27933
>> * name-lookup.c (lookup_qualified_name): Always return error_mark_node
>> if lookup fails.
>
>> + if (t)
>> + return t;
>> return error_mark_node;
>
> I know this is really pedantic, but I'd rather this be:
I always compile my code with -pedantic, so review with -pedantic
enabled is OK with me. ;-)
> if (!t)
> return error_mark_node;
>
> return t;
>
> The point is that then the end of the function shows you what's being
> returned "most of the time".
>
> The patch is OK with or without that change, though, since I don't feel
> justified in asking you to conform to this particular stylistic preference.
Committed with that change.
Regards,
Volker