This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix PR c++/27933: ICE with invalid "using"


Volker Reichelt wrote:

> 2006-06-07  Volker Reichelt  <reichelt@igpm.rwth-aachen.de>
> 
> 	PR c++/27933
> 	* name-lookup.c (lookup_qualified_name): Always return error_mark_node
> 	if lookup fails.

> +  if (t)
> +    return t;
>    return error_mark_node;

I know this is really pedantic, but I'd rather this be:

  if (!t)
    return error_mark_node;

  return t;

The point is that then the end of the function shows you what's being
returned "most of the time".

The patch is OK with or without that change, though, since I don't feel
justified in asking you to conform to this particular stylistic preference.

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]