This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] [4.2 projects] vectorize type conversions - 1/6 (updated versus r114433)


On 6/6/06, Victor Kaplansky <VICTORK@il.ibm.com> wrote:
This is updated version of "vectorize type conversions - 1/6" patch,
originally sent by Dorit in
http://gcc.gnu.org/ml//gcc-patches/2006-02/msg00940.html

-- Victor

This is a cleanup towards incorporating the new functionality:
Handling of aligned and unaligned loads can be largely unified, resulting
in a more readable code and avoids code duplication.

Bootstrapped with vectorization enabled and tested on the vectorizer
testcases on powerpc-linux.

ok for mainline?

+ /* <2> */ What are the <1>/<2>/<3> tags refering to?

+  /*
  if (alignment_support_cheme == dr_aligned
      || alignment_support_cheme == dr_unaligned_supported)
    {
-      /* Create:
+      Create:
         p = initial_addr;
         indx = 0;
         loop {
...
Instead of using pseudo-code to comment the following code, you should put
an english sentence above the created code examples.

Otherwise this looks like a good cleanup (which I cannot approve, though).

Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]