This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [committed] clean up testcases for darwin targets


> 
> 
> 
> --Apple-Mail-2--810800480
> Content-Transfer-Encoding: 7bit
> Content-Type: text/plain;
> 	charset=US-ASCII;
> 	delsp=yes;
> 	format=flowed
> 
> So, darwin for better or worse defaults to PIC. There are a bunch of  
> testcases failing for x86 that are normally skipped if -fPIC is  
> passed on the command line. We should just skip those for darwin  
> targets as well. There's also one that is only valid in the non-pic  
> case, but if we skip the clobbering of ebx we should be ok.
> 
> tested on x86-darwin with no regressions. brings us down to 19  
> failures in C land that appear to mostly be valid. (visibility-11 and  
> pragma-pack-3 are iffy).
> 
> I think that this qualifies as pretty obvious so I'm just committing.
> 
> -eric
> 
> 2006-06-02  Eric Christopher  <echristo@apple.com>
> 
> 	* gcc.c-torture/compile/20000804-1.c: Skip if darwin.

Skiping on all darwin systems is wrong as this test runs works on PowerPC darwin,
just not x86 Darwin.

> 	* gcc.target/i386/20020523-1.c: Ditto.
> 	* gcc.target/i386/asm-3.c: Ditto.
> 	* gcc.target/i386/20011119-1.c: Ditto.
> 	* gcc.target/i386/clobbers.c: Remove pic part of test.

These seems reasonable.

-- Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]