This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PING: [patch] Fix PR c/27718: ICE with sizeof of incomplete type


Volker Reichelt wrote:
On 29 May, Bernd Schmidt wrote:
Volker Reichelt wrote:
On 29 May, Bernd Schmidt wrote:
This looks ok except for the formatting of the ?: operator.
Should I write it like this?
+  pop_maybe_used (type != error_mark_node
+		  ? C_TYPE_VARIABLE_SIZE (type) : false);
Better. Basically, align with the character after the opening paren.

Well, that's what I did. It only looks unaligned in the diff output because the lower line contains tabs while the upper line doesn't. The question mark is right under the "t" of "type".

I was talking about the first version which looked like it had the ":" shifted to match the "?".


Ok then?

Sure.



Bernd



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]