This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] cse (canon_reg): Don't modify insns without using validate_change

From: Bernd Schmidt <bernds_cb1 at t-online dot de>
To: Andreas Krebbel <krebbel1 at de dot ibm dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Tue, 30 May 2006 13:30:28 +0200
Subject: Re: [PATCH] cse (canon_reg): Don't modify insns without using validate_change
References: <20060530080425.GA3122@de.ibm.com>

Andreas Krebbel wrote:

	* cse.c (validate_canon_reg, cse_insn): Don't change insns without
	calling recog.

In your previous mail you mentioned the need to call apply_change_group after canon_reg; I see places in cse.c where that isn't done. Why don't we need to change them?

Also, the comment at the top of canon_reg seems out of date with this change.

Bernd

Follow-Ups:
- Re: [PATCH] cse (canon_reg): Don't modify insns without using validate_change
  - From: Andreas Krebbel

References:
- [PATCH] cse (canon_reg): Don't modify insns without using validate_change
  - From: Andreas Krebbel

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]