This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING: [patch] Fix PR c/27718: ICE with sizeof of incomplete type
On 29 May, Bernd Schmidt wrote:
> Volker Reichelt wrote:
>> On 29 May, Bernd Schmidt wrote:
>>> This looks ok except for the formatting of the ?: operator.
>>
>> Should I write it like this?
>
>> + pop_maybe_used (type != error_mark_node
>> + ? C_TYPE_VARIABLE_SIZE (type) : false);
>
> Better. Basically, align with the character after the opening paren.
Well, that's what I did. It only looks unaligned in the diff output
because the lower line contains tabs while the upper line doesn't.
The question mark is right under the "t" of "type".
Ok then?
Regards,
Volker