This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PING: [patch] Fix PR c/27718: ICE with sizeof of incomplete type

From: Bernd Schmidt <bernds_cb1 at t-online dot de>
To: Volker Reichelt <reichelt at igpm dot rwth-aachen dot de>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 29 May 2006 18:45:26 +0200
Subject: Re: PING: [patch] Fix PR c/27718: ICE with sizeof of incomplete type
References: <tkrat.5e0872fb4ec9ae65@igpm.rwth-aachen.de> <447B1EA5.8020405@t-online.de> <tkrat.3565444952f6fc1e@igpm.rwth-aachen.de>

Volker Reichelt wrote:

On 29 May, Bernd Schmidt wrote:
This looks ok except for the formatting of the ?: operator.
Should I write it like this?

+  pop_maybe_used (type != error_mark_node
+		  ? C_TYPE_VARIABLE_SIZE (type) : false);

Better. Basically, align with the character after the opening paren.

Bernd

Follow-Ups:
- Re: PING: [patch] Fix PR c/27718: ICE with sizeof of incomplete type
  - From: Volker Reichelt

References:
- PING: [patch] Fix PR c/27718: ICE with sizeof of incomplete type
  - From: Volker Reichelt
- Re: PING: [patch] Fix PR c/27718: ICE with sizeof of incomplete type
  - From: Bernd Schmidt
- Re: PING: [patch] Fix PR c/27718: ICE with sizeof of incomplete type
  - From: Volker Reichelt

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]