This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR rtl-optimization/27661 (reload problem)
- From: Roger Sayle <roger at eyesopen dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 23 May 2006 08:49:14 -0600 (MDT)
- Subject: Re: [PATCH] Fix PR rtl-optimization/27661 (reload problem)
Hi Ulrich,
On Tue, 23 May 2006, Ulrich Weigand wrote:
> ChangeLog:
>
> PR rtl-optimization/27661
> * reload.c (find_reloads): When reloading a VOIDmode constant
> as address due to an EXTRA_MEMORY_CONSTRAINT or 'o' constraint,
> use Pmode as mode of the reload register.
>
> testsuite/ChangeLog:
>
> PR rtl-optimization/27661
> * gcc.dg/pr27661.c: New test case.
The patch itself looks reasonable, but are you able to test it on
anything more than the s390*? Once its been on mainline for a while
without problems, it looks to be safe enough for the branches, but
I was wondering if we could at least test it on a primary platform
or two, before committing to mainline. I appreciate that the change
should only affect code that currently fails, but reload patches
make me nervous, especially during stage3.
I'll preapprove this patch for mainline, once its had a little more
testing.
Thanks for fixing this.
Roger
--