This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR C++/27592, dynamic_cast fails sometimes

From: Mark Mitchell <mark at codesourcery dot com>
To: Andrew Pinski <pinskia at physics dot uc dot edu>
Cc: "gcc-patches at gcc dot gnu dot org Patches" <gcc-patches at gcc dot gnu dot org>
Date: Sun, 21 May 2006 16:20:07 -0700
Subject: Re: [PATCH] Fix PR C++/27592, dynamic_cast fails sometimes
References: <451546EA-5AD4-47F0-BBBC-DD8E32FA39A1@physics.uc.edu> <4470F2D9.4020800@codesourcery.com> <B7D40434-6459-4301-8904-3E26AA28894E@physics.uc.edu>

Andrew Pinski wrote:
> 
> On May 21, 2006, at 4:08 PM, Mark Mitchell wrote:
> 
>> Andrew Pinski wrote:
>>
>>>     * rtti.c (build_dynamic_cast_1): Create a NE_EXPR for the first
>>>     operand of the COND_EXPR.
>>
>> Right idea.
>>
>>> +          neq = build2 (NE_EXPR, boolean_type_node, result,
>>> +                cp_convert (TREE_TYPE (result), integer_zero_node));
>>
>> Juse use c_common_truthvalue_conversion (result);
> 
> I just copied what was in that file already in ifnonnull.

That doesn't make it optimal.  Please try the method I suggest, and, if
that works, consider patching the other occurrence as well.

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

References:
- [PATCH] Fix PR C++/27592, dynamic_cast fails sometimes
  - From: Andrew Pinski
- Re: [PATCH] Fix PR C++/27592, dynamic_cast fails sometimes
  - From: Mark Mitchell
- Re: [PATCH] Fix PR C++/27592, dynamic_cast fails sometimes
  - From: Andrew Pinski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]