This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ PATCH] warning about empty extern "C" structures


Roman Kononov wrote:

> The warning should be independent of -Wsystem-headers. The whole point of
> the warning is to locate the bad spots and be aware of them. The worst
> situation is when the bad spot is deeply in the system.

I disagree; -Wno-system-headers is meant to suppress all warnings from
system headers, and I don't think we should change that just for this
warning.  Users who want this warning can use -Wsystem-headers along
with this new -W option.

>> Still, I think the warning itself is OK.  However, the patch is
>> incomplete, because it is missing invoke.texi documentation.  (It would
>> sure be nice to auto-generate that from texinfo fragments in .opt files,
>> but...)
> 
> Hopefully, I can produce it, if the the patch is going to be accepted.

Oh, you shouldn't feel you need to change the way the manual is
generated for this patch; just put it in invoke.texi.

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]