This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] for PR27335
- From: Roger Sayle <roger at eyesopen dot com>
- To: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 8 May 2006 20:10:23 -0600 (MDT)
- Subject: Re: [patch] for PR27335
Hi Zdenek,
On Mon, 8 May 2006, Zdenek Dvorak wrote:
>
> PR rtl-optimization/27335
> * loop-unroll.c (peel_loops_completely): Use loops->parray to walk the
> loops.
This is OK for mainline, provided that you add the testcase from the
bugzilla PR to the testsuite. And make sure not to accidentally
commit the Makefile.in change (that added -funroll-loops to BOOT_CFLAGS)
which was inadventantly included in your submission posting :-)
Though I do approve of and appreciate this additional testing.
As this is a 4.0 and 4.1 regression, this is also OK for the release
branches, after a few days on mainline without problems. But please
bootstrap and regression test on the branches (preferably additionally
with -funroll-loops in BOOT_CFLAGS) before committing.
Thanks for fixing this.
Roger
--