This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [committed] PR target/25871: Fix MIPS trampolines for Pmode == DImode
- From: Richard Sandiford <richard at codesourcery dot com>
- To: Thiemo Seufer <ths at networkno dot de>
- Cc: gcc-patches at gcc dot gnu dot org, kumba at gentoo dot org
- Date: Tue, 02 May 2006 14:19:32 +0100
- Subject: Re: [committed] PR target/25871: Fix MIPS trampolines for Pmode == DImode
- References: <87aca0y4e4.fsf@talisman.home> <20060502131327.GE5004@networkno.de>
Thiemo Seufer <ths@networkno.de> writes:
> Richard Sandiford wrote:
>> +#define TRAMPOLINE_TEMPLATE(STREAM) \
>> +{ \
>> + if (ptr_mode == DImode) \
>> + fprintf (STREAM, "\t.word\t0x03e0082d\t\t# dmove $1,$31\n"); \
>> + else \
>> + fprintf (STREAM, "\t.word\t0x03e00821\t\t# move $1,$31\n"); \
>
> It probably makes sense to use explicitly "addu" and "daddu" in the
> comments, this avoids confusion caused by a non-existing "dmove"
> assembler macro.
I disagree. It's a comment after all, and I think the meaning
is crystal clear.
Richard