This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C PATCH] New -Woverflow option, pass OPT_Woverflow to warning.
- From: Roger Sayle <roger at eyesopen dot com>
- To: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 30 Apr 2006 16:24:30 -0600 (MDT)
- Subject: Re: [C PATCH] New -Woverflow option, pass OPT_Woverflow to warning.
Hi Gaby,
Thanks for the review.
On 1 May 2006, Gabriel Dos Reis wrote:
> The patch is welcome in principle. However, since we are supposed to
> be in stage 3, my natural question is: does it fix a regression? If
> the answer is not, then please hold it for stage 1.
There are a number of TREE_OVERFLOW releated regressions, including
some bad constant folding interactions in the Ada front-end, that
Mark and I are hoping to fix for 4.2, by cleaning up TREE_OVERFLOW.
It's because we're in stage3 that I'm trying to split this reorganization
into a number of very safe incremental improvements.
See http://gcc.gnu.org/ml/gcc-patches/2006-04/msg00889.html
and http://gcc.gnu.org/ml/gcc/2006-04/msg00008.html where it
was agreed this is reasonable for stage3 provided I'm careful.
> Is -Woverflow supposed to be actived by default, or part of -Wall?
The intention is for there to be no change of behaviour with this
patch. Currently we generate warnings unconditionally, so this
patch preserves this functionality, and enables Woverflow by default.
Roger
--