This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: Fixing incorrect DWARF2 DW_AT_location values in targets that use LEAF_REG_REMAP
- From: "David S. Miller" <davem at davemloft dot net>
- To: nickc at redhat dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 26 Apr 2006 15:20:47 -0700 (PDT)
- Subject: Re: RFA: Fixing incorrect DWARF2 DW_AT_location values in targets that use LEAF_REG_REMAP
- References: <m33bg0qfdl.fsf@redhat.com>
From: Nick Clifton <nickc@redhat.com>
Date: Wed, 26 Apr 2006 20:57:26 +0100
Thanks for finding this bug. But about the patch:
> #ifdef LEAF_REG_REMAP
> - regno = LEAF_REG_REMAP (regno);
> + {
> + unsigned leaf_reg;
> +
> + leaf_reg = LEAF_REG_REMAP (regno);
> + if (leaf_reg != -1)
> + regno = leaf_reg;
> + }
> #endif
Testing an "unsigned" against a negative quantity?
Any reason not to use plain "int" here?