This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Section Anchors and named sections
- From: Roger Sayle <roger at eyesopen dot com>
- To: David Edelsohn <dje at watson dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 25 Apr 2006 07:55:32 -0600 (MDT)
- Subject: Re: [PATCH] Section Anchors and named sections
Hi David,
On Fri, 21 Apr 2006, David Edelsohn wrote:
>
> * varasm.c (align_variable): New function.
> (get_block_for_decl): Apply align_variable to DECL before
> calculating section information. Reject DECLs with any
> SECTION_STYLE set.
> (assemble_variable): Split out alignment computation.
This is OK for mainline. Thank for your clear explanations and
to Richard Sandiford for confirming this is a reasonable approach.
My one thought was that there seems to be no reason for the new
split-out "align_variable" function to return a result and not
be void. This may also explain why the return value isn't
documented in the comment above align_variable. Feel free to
either change this to "void" or to add a comment to the effect
that this function always returns its DECL argument.
Presumably bootstrap and regression testing have now passed without
problems, and this fix silences the "... causes a section type
conflict" diagnostics building libstdc++-v3 on AIX?
Thanks again.
Roger
--