This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, fortran] PR27122 - requirements for defined operators


On Mon, Apr 17, 2006 at 04:56:51PM +0200, Paul Thomas wrote:

Hi Paul,

my hat is off to you - the speed at which you produce these patches
is amazing.

> Regtested on FC3/Athlon.  Ok for trunk and 4.1?

Yes, with one minor nit:

> +      module procedure foo_0 ! { dg-error "must have at least one argument" }
> +      module procedure foo_1 ! { dg-error "must be INTENT" }
> +      module procedure foo_2 ! { dg-error "connot be optional" }
> +      module procedure foo_3 ! { dg-error "must have, at most, two arguments" }
> +      module procedure foo_1_OK
> +      module procedure foo_2_OK
> +      function foo_chr (chr) ! { dg-error "cannot be assumed character length" }
> +       character(*) :: foo_chr
> +       character(*), intent(in) :: chr
> +      end function foo_chr

In the patch, you also check that the defined operators also must be
functions.  Can you add a line for this?

	Thomas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]