This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Dejagnu testsuite for GNAT
- From: Janis Johnson <janis187 at us dot ibm dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Janis Johnson <janis187 at us dot ibm dot com>, Ben Elliston <bje at au1 dot ibm dot com>, "James A. Morrison" <phython at gcc dot gnu dot org>
- Date: Tue, 11 Apr 2006 10:57:19 -0700
- Subject: Re: [PATCH] Dejagnu testsuite for GNAT
- References: <200604100925.41409.ebotcazou@adacore.com>
On Mon, Apr 10, 2006 at 09:25:41AM +0200, Eric Botcazou wrote:
> Hi,
>
> This is the long overdue Dejagnu testsuite harness for the GNAT compiler,
> almost entirely the work of Jim. As Jim correctly envisioned, find_gnatmake
> from libgloss.exp needs to be patched; while I was at it, I totally rewrote
> it and modelled it more closely on find_gcc/g++/gcj.
Will this work without a new release of DejaGnu? If the changes to
find_gnatmake are needed then we should find a way to add them to GCC's
test support; there are other places where we override DejaGnu procs, as
with dg-test in lib/gcc-dg.exp.
The GCC testsuite changes are quite straightforward, but I've got a few
requests:
For new files in the patch, do "diff -u" against /dev/null or an empty
file.
Use the new FSF address.
Correct the spelling of DejaGnu in the comments.
Remove ';' at the end of lines; it isn't needed.
Janis