This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: fortran/25619: temporary array of constant size character type goes wrong
- From: "H. J. Lu" <hjl at lucon dot org>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Mon, 3 Apr 2006 18:22:39 -0700
- Subject: Re: PATCH: fortran/25619: temporary array of constant size character type goes wrong
- References: <20060404010723.GA15662@lucon.org> <200604040108.k3418TT7007597@earth.phy.uc.edu>
On Mon, Apr 03, 2006 at 09:08:29PM -0400, Andrew Pinski wrote:
> >
> > On Mon, Apr 03, 2006 at 08:51:40PM -0400, Andrew Pinski wrote:
> > > >
> > > > When we copy temporary character array, we always deference the
> > > > result even if it shouldn't be deferenced. This patch checks if
> > > > the result is a pointer before deferencing it.
> > > >
> > > >
> > > > H.J.
> > > > --
> > > > 2006-04-03 H.J. Lu <hongjiu.lu@intel.com>
> > > >
> > > > PR fortran/25619
> > > > * trans-array.c (gfc_conv_expr_descriptor): Only dereference
> > > > character pointer when copying temporary.
> > >
> > > Testcase?
> > >
> >
> > I have been using this.
>
> How about adding it to the testsuite :).
>
> Or did you forgot the normal rules for the nth time?
>
I don't know much about Fortran. I was hoping someone would review my
patch and came up with a real testcase.
H.J.