This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] SPARC psABI fix, callee returns struct checking.
Carlos O'Donell wrote:
> On Wed, Mar 22, 2006 at 02:21:25PM -0800, Richard Henderson wrote:
>> Supposing that you actually need the unspec at all. I see
>> commentary that claims that the compiler expects the return
>> address to be constant, but I'd like some explanation as to
>> why and where.
>
> Ping?
>
> http://gcc.gnu.org/ml/gcc-patches/2006-03/msg01490.html
In reviewing the audit trail, I see that David Miller signed off on the
SPARC part of an earlier version of the patch, and there have been no
changes since that point, except to remove an unspec you didn't need.
The machine-independent part of the patch is now minimal; you're passing
"2" instead of "1", and since that parameter is documented as a boolean,
that should be a safe change for other back ends.
So, I think this patch is OK. If you do not hear objections from the
SPARC maintainers or RTH by close-of-business Monday, this patch is OK.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713