This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Patch: Remove fastjar
- From: Tom Tromey <tromey at redhat dot com>
- To: Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Cc: Java Patch List <java-patches at gcc dot gnu dot org>
- Date: 30 Mar 2006 15:53:27 -0700
- Subject: Patch: Remove fastjar
- Reply-to: tromey at redhat dot com
This removes fastjar from the tree, as requested by the GCC SC.
In order to build libjava, you will now need an external 'jar'
executable; libjava/configure will search for 'jar' and 'fastjar'.
fastjar doesn't have a home yet. It was rejected from savannah
because fastjar.texi is GPL and not GFDL. Most likely I will import
fastjar into the rhug repository on sourceware.org (and then fix it up
to actually build). In any case I don't think this issue should
affect whether or not this patch is committed.
I didn't include the generated diffs or the diff which actually
removes the fastjar directory.
Built on x86 FC4. Ok for trunk?
Tom
:ADDPATCH build:
2006-03-30 Tom Tromey <tromey@redhat.com>
* Makefile.def: Removed all mention of fastjar.
* Makefile.tpl: Removed all mention of fastjar.
2006-03-30 Tom Tromey <tromey@redhat.com>
* Makefile.in: Rebuilt.
* Makefile.am (ZIP): Removed.
(libgcj-$(gcc_version).jar): Use $(JAR).
(src.zip): Likewise.
* configure: Rebuilt.
* configure.ac: Check for jar. Removed code to set ZIP.
Index: Makefile.def
===================================================================
--- Makefile.def (revision 112544)
+++ Makefile.def (working copy)
@@ -47,7 +47,6 @@
host_modules= { module= diff; };
host_modules= { module= dosutils; no_check= true; };
host_modules= { module= etc; };
-host_modules= { module= fastjar; no_check_cross= true; };
host_modules= { module= fileutils; };
host_modules= { module= findutils; };
host_modules= { module= find; };
@@ -378,11 +377,6 @@
dependencies = { module=all-sim; on=all-readline; };
dependencies = { module=all-sim; on=configure-gdb; };
-// Other host modules.
-dependencies = { module=all-fastjar; on=all-zlib; };
-dependencies = { module=all-fastjar; on=all-build-texinfo; };
-dependencies = { module=all-fastjar; on=all-libiberty; };
-
// Warning, these are not well tested.
dependencies = { module=all-autoconf; on=all-m4; };
dependencies = { module=all-autoconf; on=all-build-texinfo; };
@@ -433,14 +427,10 @@
lang_env_dependencies = { module=zlib; };
dependencies = { module=configure-target-boehm-gc; on=configure-target-qthreads; };
-dependencies = { module=configure-target-fastjar; on=configure-target-zlib; };
-dependencies = { module=all-target-fastjar; on=all-target-zlib; };
-dependencies = { module=all-target-fastjar; on=all-target-libiberty; };
dependencies = { module=configure-target-libjava; on=configure-target-zlib; };
dependencies = { module=configure-target-libjava; on=configure-target-boehm-gc; };
dependencies = { module=configure-target-libjava; on=configure-target-qthreads; };
dependencies = { module=configure-target-libjava; on=configure-target-libffi; };
-dependencies = { module=all-target-libjava; on=all-fastjar; };
dependencies = { module=all-target-libjava; on=all-target-zlib; };
dependencies = { module=all-target-libjava; on=all-target-boehm-gc; };
dependencies = { module=all-target-libjava; on=all-target-qthreads; };
Index: Makefile.tpl
===================================================================
--- Makefile.tpl (revision 112544)
+++ Makefile.tpl (working copy)
@@ -567,7 +567,7 @@
-rm -f texinfo/doc/Makefile texinfo/po/POTFILES
-rmdir texinfo/doc texinfo/info texinfo/intl texinfo/lib 2>/dev/null
-rmdir texinfo/makeinfo texinfo/po texinfo/util 2>/dev/null
- -rmdir fastjar gcc libiberty texinfo zlib 2>/dev/null
+ -rmdir gcc libiberty texinfo zlib 2>/dev/null
local-maintainer-clean:
@echo "This command is intended for maintainers to use;"
Index: libjava/configure.ac
===================================================================
--- libjava/configure.ac (revision 112544)
+++ libjava/configure.ac (working copy)
@@ -116,6 +116,10 @@
AC_CHECK_TOOL(LD, ld)
AC_CHECK_TOOL(AR, ar)
AC_CHECK_TOOL(RANLIB, ranlib, :)
+AC_CHECK_PROGS(JAR, [jar fastjar], false)
+if test "$JAR" = false; then
+ AC_MSG_ERROR(jar program not found)
+fi
AC_PROG_INSTALL
@@ -289,7 +293,6 @@
built)
GCJ="$built_gcc_dir/gcj -B`${PWDCMD-pwd}`/ -B$built_gcc_dir/"
GCJH='$(top_builddir)/$(MULTIBUILDTOP)../../$(host_subdir)/gcc/gcjh'
- ZIP='$(top_builddir)/$(MULTIBUILDTOP)../../$(host_subdir)/fastjar/fastjar'
;;
cross)
if test "x${with_newlib}" = "xyes"; then
@@ -299,20 +302,15 @@
else
GCJ="${target_noncanonical}-gcj -B`${PWDCMD-pwd}`/"
fi
- ZIP='$(target_noncanonical)-fastjar'
GCJH='$(target_noncanonical)-gcjh'
;;
path)
GCJ="gcj -B`${PWDCMD-pwd}`/"
- ## In this case, gcj is found outside the build tree. However, zip is
- ## found in the build tree.
- ZIP='$(top_builddir)/$(MULTIBUILDTOP)../$(COMPPATH)/fastjar/fastjar'
GCJH=gcjh
;;
esac
AC_SUBST(GCJH)
-AC_SUBST(ZIP)
# Create it, so that compile/link tests don't fail
test -f libgcj.spec || touch libgcj.spec
Index: libjava/Makefile.am
===================================================================
--- libjava/Makefile.am (revision 112544)
+++ libjava/Makefile.am (working copy)
@@ -87,7 +87,6 @@
##
GCJH = @GCJH@
-ZIP = @ZIP@
## The compiler with whatever flags we want for both -c and -C
## compiles.
@@ -322,10 +321,7 @@
$(LTGCJCOMPILE) -o $@ -c $< -Wc,--resource,$(@:.lo=)
libgcj-$(gcc_version).jar:
- jardir=`dirname $(ZIP)`; \
- jardir=`cd $$jardir && pwd`; \
- jarname=`basename $(ZIP)`; \
- cd classpath/lib; $$jardir/$$jarname -cfM \
+ cd classpath/lib; $(JAR) -cfM \
../../libgcj-$(gcc_version).jar gnu java javax org
CLEANFILES = libgcj-$(gcc_version).jar \
@@ -883,9 +879,10 @@
echo $$file; \
done ); \
) | \
-## Many of the above circumlocutions are because ZIP will most likely
-## be a relative path to fastjar.
- $(ZIP) -cfM@ $$here/src.zip
+## Many of the above circumlocutions were because ZIP used to be a
+## relative path to fastjar. It didn't seem worthwhile to change the
+## code when we moved to an external jar.
+ $(JAR) -cfM@ $$here/src.zip
## Override GNU Classpath sources with libgcj replacements.
here=`pwd`; \
( \
@@ -897,7 +894,7 @@
echo $$file; \
done ); \
) | \
- $(ZIP) -ufM@ $$here/src.zip
+ $(JAR) -ufM@ $$here/src.zip
## We use a variable for this in case the user wants to override it.
sourcesdir = $(jardir)