This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: pr25569

From: Jan-Benedict Glaw <jbglaw at lug-owl dot de>
To: Jeffrey A Law <law at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Wed, 22 Mar 2006 20:38:59 +0100
Subject: Re: pr25569
References: <1143050430.14469.56.camel@to-dhcp19.toronto.redhat.com>

On Wed, 2006-03-22 11:00:29 -0700, Jeffrey A Law <law@redhat.com> wrote:
> *** gcc/loop-unroll.c	(revision 112242)
> --- gcc/loop-unroll.c	(working copy)
> ! 
> !      Returning NULL when iv_analyze_result returns false is safe and
> !      avoids the problems in pr25569 until the iv_analyze_* routines
> !      can be fixed, which is apparently hard and time consuming
> !      according to their author.  */
> !   if (! ok)
> !     return NULL;
>   
>     if (iv.step == const0_rtx
>         || iv.mode != iv.extend_mode)

Shouldn't this read  "if (!ok)" wrt.
http://gcc.gnu.org/codingconventions.html ?

MfG, JBG

-- 
Jan-Benedict Glaw       jbglaw@lug-owl.de    . +49-172-7608481             _ O _
"Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg  _ _ O
 fÃr einen Freien Staat voll Freier BÃrger"  | im Internet! |   im Irak!   O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

Attachment: signature.asc
Description: Digital signature

References:
- pr25569
  - From: Jeffrey A Law

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]