This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Avoid console windows on Win32
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Danny Smith <dannysmith at clear dot net dot nz>
- Cc: 'GCC-patches' <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 22 Mar 2006 00:52:00 -0800
- Subject: Re: PATCH: Avoid console windows on Win32
- References: <000001c64d8c$7f0e94a0$a76d65da@anykey>
Danny Smith wrote:
>
>> -----Original Message-----
>> From: Mark Mitchell
>> Sent: Wednesday, March 22, 2006 11:05 AM
>> To: Danny Smith
>>
>> Danny Smith wrote:
>>
>>> This breaks -pipe switch,
>> Thanks for testing!
>>
>> I *think* that's actually a pre-existing problem, which I
>> fixed last night. pex_run creates the pipe, but doesn't
>> close the write end of the pipe, in the parent.
>
> Yes, it is a pre-existing problem.
>> If you add:
>>
>> p[READ_PORT] = -1;
>> p[WRITE_PORT] = -1;
>>
>> at the top of the function and:
>>
>> if (p[WRITE_PORT] != -1)
>> obj->funcs->close (obj, p[WRITE_PORT]);
>>
>> after the call to exec_child, does that fix it?
>
> This is what I tried. It doesn't fix it.
Weird. I was just now verifying that this exact patch worked for me --
and it does seem to do so for me. How odd...
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713