This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch to gcc to allow the linux kernel to use -fstack-protector
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Arjan van de Ven <arjan at linux dot intel dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 18 Mar 2006 13:20:46 -0300
- Subject: Re: Patch to gcc to allow the linux kernel to use -fstack-protector
- References: <1142677494.2889.15.camel@laptopd505.fenrus.org>
On Mar 18, 2006, Arjan van de Ven <arjan@linux.intel.com> wrote:
> + if (TARGET_64BIT) {
The '{' must always come on a different line, by itself.
> + } else
Ditto '}'
> + (unspec:DI [(match_operand:DI 1 "const_int_operand" "i")] UNSPEC_SP_TLS_SET_KERNEL))
A line break before the UNSPEC_ name would probably be good, to avoid
the long line, but I see you just copied this from another violator.
> (include "sync.md")
> +
This new line is probably unintended.
Other than that, the patch looks quite reasonable, although I'm not
sure I understand why the kernel would choose to depart from the
userland ABI as far as TLS goes. Is there a very good reason for
that?
--
Alexandre Oliva http://www.lsd.ic.unicamp.br/~oliva/
Secretary for FSF Latin America http://www.fsfla.org/
Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}