This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Use define_constraint for MIPS
- From: Zack Weinberg <zackw at panix dot com>
- To: Richard Sandiford <richard at codesourcery dot com>
- Cc: echristo at apple dot com, gcc-patches at gcc dot gnu dot org
- Date: Thu, 9 Mar 2006 11:19:08 -0500
- Subject: Re: Use define_constraint for MIPS
Just a few comments:
* You should change the MIPS "Machine Constraints" block to refer to
config/mips/constraints.md rather than config/mips/mips.h.
* Speaking of which, when I did i386 I put the constraints at the end
of the existing predicates.md. I don't have a strong opinion on which
style is better, but we should probably be consistent across architectures.
* Are the docstrings consistent with the existing manual? When I did
i386, I mimiced the (yet-to-be-written) docstring-to-manual conversion
by hand.
* I see a lot of constraints whose docstrings are just '@internal' with
no further explanation. Is there any hope of getting real documentation
for those?
zw