This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] SPARC psABI fix, callee returns struct checking.
- From: Eric Botcazou <ebotcazou at libertysurf dot fr>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Carlos O'Donell <carlos at codesourcery dot com>, "David S. Miller" <davem at davemloft dot net>, rth at redhat dot com, jakub at redhat dot com
- Date: Thu, 9 Mar 2006 09:36:13 +0100
- Subject: Re: [PATCH] SPARC psABI fix, callee returns struct checking.
- References: <20060308223803.GA11591@lios> <200603090816.29574.ebotcazou@libertysurf.fr> <440FD66E.3040605@codesourcery.com>
> I don't think we need to worry about the default. Imagine that Carlos
> is busily adding a switch and that it will be off by default. :-)
Agreed.
> It would still be helpful if you could review the other bits, so that
> Carlos can know whether they look OK.
I think introducing a flag could substantially change the patch so a very
detailed review must probably wait until after the revised patch is posted.
A few remarks though:
1. Very well-written patch, very clear and documented. :-)
2. Would all the front-ends not need to be patched like c-typeck.c?
3. The name STRUCT_PROLOGUE is a bit misleading, I'd rather have
STRUCT_RETURN_CHECK or something along these lines.
4. Insns in delay slots must be indented (1 space).
--
Eric Botcazou