Re: [patch] Fix fortran/25031, multiple allocations

[Thomas Koenig <Thomas dot Koenig at online dot de>]

On Thu, Mar 02, 2006 at 08:53:45PM +0100, Paul Thomas wrote:

Hi Paul,

> OK.

Thanks!

> 
> Before you commit, you might like to take a look at my version, which is 
> attached.  The TREE work does produce more cumbersome looking 
> code(attached is the code for your testcase) than yours (or at least 
> many more braces), it could do with special treatment for constant sizes 
> and needs a proper code for stat.  However, it is an amusing 
> self-education exercise and you might care to incorporate the interface 
> to gfc_allocate array.

I found it quite interesting (especially because I am currently trying
to learn walking with TREEs).   I have also incorporated your change.

For the record, this is what I committed.

	Thomas

2006-03-03  Thomas Koenig  <Thomas.Koenig@online.de>

	PR fortran/25031
	* trans-array.h:  Adjust gfc_array_allocate prototype.
	* trans-array.c (gfc_array_allocate):  Change type of
	gfc_array_allocatate to bool.  Function returns true if
	it operates on an array.  Change second argument to gfc_expr.
	Find last reference in chain.
	If the function operates on an allocatable array, emit call to
	allocate_array() or allocate64_array().
	* trans-stmt.c (gfc_trans_allocate):  Code to follow to last
	reference has been moved to gfc_array_allocate.
	* trans.h:  Add declaration for gfor_fndecl_allocate_array and
	gfor_fndecl_allocate64_array.
	(gfc_build_builtin_function_decls):  Add gfor_fndecl_allocate_array
	and gfor_fndecl_allocate64_array.

2006-03-03  Thomas Koenig  <Thomas.Koenig@online.de>

	PR fortran/25031
	* runtime/memory.c:  Adjust copyright years.
	(allocate_array):  New function.
	(allocate64_array):  New function.
	* libgfortran.h (error_codes):  Add ERROR_ALLOCATION.

2006-03-03  Thomas Koenig  <Thomas.Koenig@online.de>

	PR fortran/25031
	* multiple_allocation_1.f90:  New test.

Attachment: alloc2-diff
Description: Text document