This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, fortran] PR25395 - equivalence to common block array broken
- From: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
- To: Paul Thomas <Paul dot Thomas at jet dot uk>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gnu dot org
- Date: Wed, 22 Feb 2006 00:27:38 +0100
- Subject: Re: [Patch, fortran] PR25395 - equivalence to common block array broken
- References: <43FB57EB.5090906@jet.uk>
Paul Thomas wrote:
> @@ -746,14 +746,19 @@
>
>
> /* Add all symbols equivalenced within a segment. We need to scan the
> - segment list multiple times to include indirect equivalences. */
> + segment list multiple times to include indirect equivalences. Since
> + a new segment_info can inserted at the beginning of the segment list,
> + depending on its offset, we have to force a final pass through the
> + loop by demanding that completion sees a pass with no matches; ie.
> + all symbols with equiv_built set and no new equivalences found.*/
^^
two blanks please.
> static void
> add_equivalences (bool *saw_equiv)
> {
> segment_info *f;
> - bool more;
> + bool seen_one, more;
>
> + seen_one = FALSE;
> more = TRUE;
> while (more)
> {
The use of upper-case booleans vs lower-case ones below lead me to
investigate: the lower case variants are the right ones.
Apart from that, this is ok.
Thanks,
- Tobi