This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [libgomp] Add Unix95 mutex support


On Thu, Feb 16, 2006 at 11:37:15AM +0100, Rainer Orth wrote:
> Eric Botcazou <ebotcazou@adacore.com> writes:
> 
> > > > I think you cannot reasonably define _XOPEN_SOURCE to 500 for Unix95.
> > >
> > > You mean it would give a hard error (#error)?
> > 
> > Most likely no.  I guess unconditionally defining shouldn't be harmful after 
> > all.
> 
> Unfortunately, it is on Tru64 UNIX V4.0F.  See PR libgomp/26308 for
> details.

While we talk about Tru64, we should really get rid of the bogus
/* Some implementations of <pthread.h> require this to be defined.  */
#ifndef _REENTRANT
#define _REENTRANT 1
#endif
that was added to gthr-posix.h to make Tru64 happy.  If Tru64 needs
something like that, it needs to do that in its own headers, not generic
ones used on all arches.  With this hunk, code that wants to see if
-pthread was or was not used on command line suddenly can't find that out,
as any code that through C++ headers includes gthr-posix.h will define
_REENTRANT, no matter if -pthread was used or not.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]