This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH - darwin] PR target/25376
- From: Josh Conner <jconner at apple dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: Roger Sayle <roger at eyesopen dot com>, David Edelsohn <dje at watson dot ibm dot com>, Mike Stump <mrs at apple dot com>, Geoffrey Keating <geoffk at geoffk dot org>, Eric Christopher <echristo at apple dot com>, Daniel Jacobowitz <drow at false dot org>
- Date: Mon, 13 Feb 2006 10:13:09 -0800
- Subject: Re: [PATCH - darwin] PR target/25376
- References: <Pine.LNX.4.44.0602111302390.13360-100000@www.eyesopen.com>
Roger Sayle wrote:
> On Fri, 3 Feb 2006, Josh Conner wrote:
>> 2006-02-03 Josh Conner <jconner@apple.com>
>>
>> PR target/25376
>> * gcc/varasm.c (function_section) Check for section name before
>> calling select_section on targets that define
>> USE_SELECT_SECTION_FOR_FUNCTIONS. On other targets, use
>> unlikely_text_section instead of hot_function_section if
>> first_function_block_is_cold.
>>
>> * lib/target-supports.exp (check_named_sections_available)
>> Only compile named-sections test -- don't assemble.
>>
>> * gcc.dg/pr25376.c: New test.
>> * gcc.c-torture/compile/pr23237.c: Only compile test -- don't
>> assemble.
>
> This is OK for mainline.
Committed as change 110917 - thanks to everyone who commented.
> I also
> appreciate DanielJ's comments that perhaps GCC should provide some
> level of "virtualization", but that's a different enhancement PR from
> this bug-fix.
Yes, that makes sense - I've entered PR target/26262 for tracking this.
- Josh