Re: Bye bye flag_const_strings

[Andrew Pinski <pinskia at physics dot uc dot edu>]

On Feb 6, 2006, at 8:15 PM, Gabriel Dos Reis wrote:

> Gabriel Dos Reis <gdr@integrable-solutions.net> writes:
>
> [...]
>
> | | The variable flag_const_strings is set by -Wwrite-strings for C.  
> If you
> | | remove the variable then the c-common.c logic for building string
> | | constants will need to change
> | |
> | |   if (flag_const_strings)
> | |
> | | to
> | |
> | |   if (c_dialect_cxx () || warn_write_strings)
> |
> | Yes,
>
> Here is the patch I'm bootstrapping right now.
>
> -- Gaby
>
> 2006-02-06  Gabriel Dos Reis  <gdr@integrable-solutions.net>
>
> 	* c-common.h (flag_const_strings): Don't declare.
> 	* c-common.c (flag_const_strings): Remove.
> 	* c.opt (fconst_strings): Remove.
> 	* c-opts.c (c_common_handle_option): Remove <OPT_fconst_strings>.
> 	<OPT_Wwrite_strings>: Don't set flag_const_strings.
> 	(c_common_init_options): Don't set flag_const_strings.
> 	* doc/invoke.texi (-fno-const-strings): Remove documentation.

This also fixes PR C++/8586 (well it is already fixed as -Wwrite-strings
is already default for C++ now).

Thanks,
Andrew Pinski