This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH to cp/: Make tf_warning | tf_error an enumeration
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 06 Feb 2006 16:43:25 -0800
- Subject: Re: PATCH to cp/: Make tf_warning | tf_error an enumeration
- References: <m3psm312va.fsf@uniton.integrable-solutions.net>
Gabriel Dos Reis wrote:
> Hi,
>
> While looking at enumeration in C vs. C++ issues, it appears
> that the mask "tf_error | tf_warning" is used a lot in the C++
> front-end; so I make it an enumeration.
The name "tf_warn_or_error" is bad; it should actually be
"tf_warning_and_error" because (a) the use of this flag means that both
warnings and errors will be emitted, and (b) both "warning" and "error"
are nouns in this context, while "warn" is a verb.
Would you please adjust the name?
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713