Re: gcc-4_1-branch backports of the long double changes

[Mark Mitchell <mark at codesourcery dot com>]

Jakub Jelinek wrote:

> That's why I separated the patches.

Thanks, good, we're on the same page!

> I think it is quite obvious that
> http://gcc.gnu.org/ml/gcc-patches/2006-02/txt00024.txt
> doesn't affect code unless -mlong-double-128 (not the default and really not
> usable on Linux up to now) on the few selected linux targets (ppc{,64},
> s390{,x}, sparc (32-bit) and alpha) plus if Hurd shares the same headers
> also on Hurd if Hurd is at all supported on those arches.

Indeed.  I'll leave it to the architecture maintainers to review the
mangling patches, but I'll be happy to help if I can, especially because
I know the C++ ABI pretty well.

> http://gcc.gnu.org/ml/gcc-patches/2006-01/msg01907.html

I have reviewed this patch, from a high level.  I'm OK with this going
on the 4.1 branch, if approved by a target maintainer.  Again, I will
review it in detail, if that's necessary, but I think this review can
best be done by a PowerPC maintainer.  I would like that maintainer who
reviews this to particularly double-check your assertion that this can't
affect -mlong-double-64 users, as part of the review; that is as
important as checking the correctness of the handling of -mlong-double-128.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713