This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: Optionally use -mlong-double-128 by default on sparc


On Fri, Feb 03, 2006 at 11:04:49PM +0100, Eric Botcazou wrote:
> > How does this look?
> 
> Mostly OK I think, but...
> 
> > +#ifdef TARGET_DEFAULT_LONG_DOUBLE_128
> > +  if (target_flags_explicit & MASK_LONG_DOUBLE_128)
> > +    target_flags |= MASK_LONG_DOUBLE_128;
> > +#endif
> 
> ... has changed since the first version (disregarding !TARGET_64BIT):
> 
> +#if defined SPARC_LINUX && defined TARGET_DEFAULT_LONG_DOUBLE_128
> +  if (!TARGET_64BIT && !(target_flags_explicit & MASK_LONG_DOUBLE_128))
> +    target_flags |= MASK_LONG_DOUBLE_128;
> +#endif
> 
> My understanding is that the first version is the correct one, but I'll let 
> Jakub and you settle that.  I also think that Andrew's suggestion is sound.

Should be:

#ifdef TARGET_DEFAULT_LONG_DOUBLE_128
  if (! (target_flags_explicit & MASK_LONG_DOUBLE_128))
    target_flags |= MASK_LONG_DOUBLE_128;
#endif

(the topmost above is missing a negation).

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]