This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: Optionally use -mlong-double-128 by default on sparc

> How does this look?

Mostly OK I think, but...

> +#ifdef TARGET_DEFAULT_LONG_DOUBLE_128
> +  if (target_flags_explicit & MASK_LONG_DOUBLE_128)
> +    target_flags |= MASK_LONG_DOUBLE_128;
> +#endif

... has changed since the first version (disregarding !TARGET_64BIT):

+#if defined SPARC_LINUX && defined TARGET_DEFAULT_LONG_DOUBLE_128
+  if (!TARGET_64BIT && !(target_flags_explicit & MASK_LONG_DOUBLE_128))
+    target_flags |= MASK_LONG_DOUBLE_128;
+#endif

My understanding is that the first version is the correct one, but I'll let 
Jakub and you settle that.  I also think that Andrew's suggestion is sound.

Thanks for the revised patch.

-- 
Eric Botcazou
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]