This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Add -fsection-anchors (4.2 project)


Andrew Pinski <pinskia@physics.uc.edu> writes:
> First I want to say thanks for doing this optimization.

Thanks ;)

> Second, this should fix PR 17106 which is actually asking for
> this optimization.

Nice.  I didn't know about that one.  I'll stick the PR number
in the changelog.

>> The only extra failures were in objc:
>> 
>>     FAIL: objc/execute/class-13.m compilation
>>     FAIL: objc/execute/class-6.m compilation
>>     FAIL: objc/execute/object_is_class.m compilation
>>     FAIL: objc/execute/object_is_meta_class.m compilation
>> 
>> (options snipped).  These failures are caused by objc creating two decls
>> for _OBJC_METACLASS_* objects.  I think it would be better to modify the
>> old decl once the initialiser is known, but I don't know enough about
>> objc to do that.
>
> Thrid, give me a few days to debug this.  If your patch is approved make sure that these
> tests get xfailed and a bug(s) filed for this regression.

OK.  My original message wasn't very clear about these failures, so in
case there's any confusion, they only occured in the bootstraps for
which -fsection-anchors was enabled by default.  The bootstraps with
the patch as posted didn't have them (or any other new failures).

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]