This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] C++ FE warning control cleanup


Would you prefer those changes to be incorporated into this patch or
into a follow-up one?

On 31 Jan 2006 21:52:25 +0100, Gabriel Dos Reis
<gdr@integrable-solutions.net> wrote:
>  writes:
>
> | > Index: typeck.c
> | > ===================================================================
> | > --- typeck.c        (revision 110412)
> | > +++ typeck.c        (working copy)
> | > @@ -1500,7 +1500,7 @@ string_conv_p (tree totype, tree exp, in
> | >
> | >    /* This warning is not very useful, as it complains about printf.  */
> | >    if (warn && warn_write_strings)
> | > -    warning (0, "deprecated conversion from string constant to %qT'", totype);
> | > +    warning (OPT_Wwrite_strings, "deprecated conversion from string constant to %qT'", totype);
> |
> | You can remove warn_write_strings from the if statement now.
>
> I saw them, but I think they can wait for another patch.
> Incremental improvements!
>
> -- Gaby
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]