This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFR: prediction values


On 2006-01-31, at 17:20, Rainer Orth wrote:

This is still not ok: the sentences should be capitalized and you should
name the functions changed. Something like

2006-01-31 Marcin Dalecki <martin@dalecki.de>

	* predict.h (enum prediction): Add NO_PREDICTION value.
	* builtins.c (expand_builtin_expect_jump): Use explicitely named
	constants.

Please check the GNU Coding Standards for details.

Yes OK. But what about the actual merit of the patch itself?

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]