This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix cygwin bootstrap failure
On Mon, Jan 30, 2006 at 04:33:58PM -0700, Roger Sayle wrote:
>The following patch restores mainline to bootstrap land on i686-pc-cygwin
>which currently failures during stage2 with a fatal warning building gcc.c
>complaining about casting "char **argv" to "const char * const *" for the
>second argument to mingw_scan.
>
>Given that mingw_scan is only called from a single place (gcc.c:main in
>the expansion of GCC_DRIVER_HOST_INITIALIZATION) there are two possible
>cures. The minimal fix below is to simply cast argv to the appropriate
>type required by mingw_scan. The alternate fix (that touches two files)
>is to change the signature of mingw_scan such that the second argument
>is of type "char**" to match its only caller. I've no strong preference
>for one vs. the other, but the proposed solution below is both smaller
>and reflects that mingw_scan doesn't internally modify its argv argument.
>
>Ok for mainline? Obvious?
>
>2006-01-30 Roger Sayle <roger@eyesopen.com>
>
> * config/i386/cygwin.h (GCC_DRIVER_HOST_INITIALIZATION): Cast
> argv to the appropriate type.
Looks good to me. Please check in.
cgf