This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] more enhancements to df on the mainline.


> @@ -1160,6 +1162,12 @@ static struct mips_rtx_cost_data const m
>  #undef TARGET_ATTRIBUTE_TABLE
>  #define TARGET_ATTRIBUTE_TABLE mips_attribute_table
>  
> +#undef TARGET_EXTRA_LIVE_ON_ENTRY
> +/* With -mabicalls (which is the default on GNU/Linux),
> +   PIC_FUNCTION_ADDR_REGNUM is live on function entry and is to
> +   initialize $28, which is PIC_OFFSET_TABLE_REGNUM.  */
> +#define TARGET_EXTRA_LIVE_ON_ENTRY mips_extra_live_on_entry
> +
>  struct gcc_target targetm = TARGET_INITIALIZER;
>  

The overrides themselves generally don't have comments, and you don't
need this one.  The comment above mips_extra_live_on_entry is fine
on its own.

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]