This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] remove darwin from libgomp's target.


I did a quick prototype to implement the libgomp semaphore using pthread condition variables. With that change:
Native configuration is powerpc-apple-darwin8.4.1


=== libgomp tests ===

Schedule of variations:
    unix

Running target unix
Using /opt/dejagnu/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /opt/dejagnu/share/dejagnu/config/unix.exp as generic interface file for target.
WARNING: Couldn't find tool config file for unix, using default.
Running /Volumes/ltmp/src/gcc/libgomp/testsuite/libgomp.c/c.exp ...


=== libgomp Summary ===

# of expected passes            122
# of unsupported tests          5

I think, preferable to disabling libgomp, would be to add an autoconf check for a working sem_init() and if it doesn't work, or you are cross-compiling to darwin, use the alternate implementation.

Shantonu

On Jan 29, 2006, at 4:18 PM, Andrew Pinski wrote:


On Jan 29, 2006, at 6:15 PM, Andreas Tobler wrote:
For now I'd appreciate just commenting it out with a comment of why. Not that I can approve it, but...

No problem with, simply commenting it out is equal to removing it or the other way round. I can update the CL comment to say why.

Also in the comment mention the bug 25978 so that the person who sees the commented out *-*-darwin knows that it is known and there is a way to fix it.

-- Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]