This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Some gengtype clean-ups


richard@codesourcery.com (Richard Sandiford)  wrote on 20.01.06 in <87vewehbcw.fsf@talisman.home>:

> +/* Create a fake field with the given type and name.  NEXT is the next
> +   field in the chain.  */
> +
> +static pair_p
> +create_field (pair_p next, type_p type, const char *name)
> +{
> +  pair_p field;
> +
> +  field = XNEW (struct pair);
> +  field->next = next;
> +  field->type = type;
> +  field->name = name;
> +  field->opt = NULL;
> +  field->line.file = __FILE__;
> +  field->line.line = __LINE__;
> +  return field;
> +}

Shouldn't this use the *caller's* __FILE__/__LINE__?

MfG Kai


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]