Re: [patch] C++ FE warning control cleanup

[Andrew Pinski <pinskia at physics dot uc dot edu>]

On Jan 28, 2006, at 3:49 PM, Lee Millward wrote:

> Hi,
>
> This patch adjusts calls to warning() in the C++ front end to not use
> 0 but instead use the appropriate OPT_W values, there was some other
> calls which I didn't change as I wasn't totally sure of the right
> value to use in it's place so this patch addresses the more obvious
> occurrences.
>
> Bootstrapped successfully on i686-pc-linux-gnu, is a regression test
> required for patches of this nature?

You ran the test suite, right?

> 2006-01-28  Lee Millward <lee.millward@gmail.com>
>
>        *typeck.c (string_conv_p, build_array_ref):
         ^missing a space
>        pass the appropriate OPT_Wxxxx warning flag when
         ^ Capital letter as this is a sentence

Also how big is the diff?  Is it really big enough to tar up
and compress it?

-- Pinski