This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: add -Wno-overlength-strings


Zack Weinberg <zackw@panix.com> writes:


[...]

| Bernd pre-approved this patch, but I'd like another pair of eyes
| on some bits: my wording in the manual, and the justification for
| not issuing this warning in C++.

C++, unlike C, imposes no standard minimum limits.

[...]

| ==================================================================
| --- c-opts.c	(revision 110316)
| +++ c-opts.c	(local)
| @@ -893,6 +893,8 @@ c_common_handle_option (size_t scode, co
|        cpp_opts->warn_endif_labels = 1;
|        if (warn_pointer_sign == -1)
|  	warn_pointer_sign = 1;
| +      if (warn_overlength_strings == -1)

should not this be

    if (warn_overlength_strings == -1 && !c_dialect_cxx())

?

-- Gaby


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]