This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: C++ PATCH: fix PR 10891

Gabriel Dos Reis wrote:

> I'm all for self-contained comments and citation to appropriate part
> of the standard.  Removing the reference to the PR does not make the
> comment less self-contained.  It serves here as a witness of our past
> failure. 

Like Nathan, I think you this is a bad documentation style; it makes for
spaghetti comments.  Please remove the PR reference.

Furthermore, I wondered a little bit as to whether we should allow
dynamic_casts that turn out not really to be dynamic, since that would
work OK technically.  I think your change is good, though, in that it's
easier to explain; no RTTI, then no dynamic_cast.

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]