This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: -mtune=generic for i386 backend
- From: Richard Henderson <rth at redhat dot com>
- To: Jan Hubicka <jh at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org, evandro dot menezes at amd dot com, hongliu dot lu at indel dot com
- Date: Tue, 17 Jan 2006 16:25:15 -0800
- Subject: Re: -mtune=generic for i386 backend
- References: <20060117232507.GK26136@kam.mff.cuni.cz>
On Wed, Jan 18, 2006 at 12:25:07AM +0100, Jan Hubicka wrote:
> + #define TARGET_CPU_DEFAULT_generic 17
>
> #define TARGET_CPU_DEFAULT_NAMES {"i386", "i486", "pentium", "pentium-mmx",\
> "pentiumpro", "pentium2", "pentium3", \
> "pentium4", "k6", "k6-2", "k6-3",\
> "athlon", "athlon-4", "k8", \
> ! "pentium-m", "prescott", "nocona", "generic"}
...
> PROCESSOR_NOCONA,
> + PROCESSOR_GENERIC32,
> + PROCESSOR_GENERIC64,
These aren't being kept in sync. IIRC that's badness. Of course,
a better question is why we have multiple enumerations...
> + /* All patterns using algined_operand on memory operands ends up
Typo.
Otherwise I don't see anything objectionable. It would be nice
to paste some of the rationale from your mail into comments at
appropriate points where generic* settings are set.
r~