This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: testsuite/25741: Gcc testsuite isn't parallel build

On Tue, Jan 17, 2006 at 09:46:45AM -0800, Developer Foo wrote:
> 2006-01-17  Shantonu Sen  <ssen@opendarwin.org>
> 
>         * Makefile.in (check-%, check-consistency): Use ${abs_srcdir},
>         since a relative path to ${srcdir} is not valid after changing to
>         the lang-specific testsuite directory

I'm confused.  The description makes sense.  But how can this patch do
anything?

> -       srcdir=`cd ${srcdir}; ${PWD_COMMAND}` ; export srcdir ; \
> +       abs_srcdir=`cd ${abs_srcdir}; ${PWD_COMMAND}` ; export abs_srcdir ; \

srcdir had better have already been absolute.

> -       $(SHELL) $(srcdir)/../move-if-change tmp-site.exp site.exp; \
> +       $(SHELL) $(abs_srcdir)/../move-if-change tmp-site.exp site.exp; \

This is the real bug, and below.  Don't use $(srcdir) or ${srcdir}, use
$${srcdir}.

-- 
Daniel Jacobowitz
CodeSourcery
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]